aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGertjan van den Burg <gertjanvandenburg@gmail.com>2017-02-21 18:46:05 -0500
committerGertjan van den Burg <gertjanvandenburg@gmail.com>2017-02-21 18:46:05 -0500
commit9cae6b1c78725360d5fbf7c507559532104cead0 (patch)
treed682ebd39f1539dc4affa6c9c9d71a10fb8eeb71
parentMinor fixes (diff)
downloadgensvm-9cae6b1c78725360d5fbf7c507559532104cead0.tar.gz
gensvm-9cae6b1c78725360d5fbf7c507559532104cead0.zip
Explicitly specify void argument to functions which take
no arguments.
-rw-r--r--include/gensvm_base.h4
-rw-r--r--include/gensvm_grid.h2
-rw-r--r--include/gensvm_queue.h2
-rw-r--r--include/gensvm_sparse.h2
-rw-r--r--include/gensvm_task.h2
-rw-r--r--src/gensvm_base.c4
-rw-r--r--src/gensvm_grid.c2
-rw-r--r--src/gensvm_kernel.c1
-rw-r--r--src/gensvm_queue.c2
-rw-r--r--src/gensvm_sparse.c3
-rw-r--r--src/gensvm_task.c2
-rw-r--r--src/gensvm_update.c1
12 files changed, 12 insertions, 15 deletions
diff --git a/include/gensvm_base.h b/include/gensvm_base.h
index 72371df..367a1b2 100644
--- a/include/gensvm_base.h
+++ b/include/gensvm_base.h
@@ -173,12 +173,12 @@ struct GenWork {
};
// function declarations
-struct GenModel *gensvm_init_model();
+struct GenModel *gensvm_init_model(void);
void gensvm_allocate_model(struct GenModel *model);
void gensvm_reallocate_model(struct GenModel *model, long n, long m);
void gensvm_free_model(struct GenModel *model);
-struct GenData *gensvm_init_data();
+struct GenData *gensvm_init_data(void);
void gensvm_free_data(struct GenData *data);
struct GenWork *gensvm_init_work(struct GenModel *model);
diff --git a/include/gensvm_grid.h b/include/gensvm_grid.h
index 900a62a..0f4319e 100644
--- a/include/gensvm_grid.h
+++ b/include/gensvm_grid.h
@@ -115,7 +115,7 @@ struct GenGrid {
};
// function declarations
-struct GenGrid *gensvm_init_grid();
+struct GenGrid *gensvm_init_grid(void);
void gensvm_free_grid(struct GenGrid *grid);
#endif
diff --git a/include/gensvm_queue.h b/include/gensvm_queue.h
index c680ebf..441b4a9 100644
--- a/include/gensvm_queue.h
+++ b/include/gensvm_queue.h
@@ -54,7 +54,7 @@ struct GenQueue {
};
// function declarations
-struct GenQueue *gensvm_init_queue();
+struct GenQueue *gensvm_init_queue(void);
void gensvm_free_queue(struct GenQueue *q);
struct GenTask *get_next_task(struct GenQueue *q);
diff --git a/include/gensvm_sparse.h b/include/gensvm_sparse.h
index f897889..ed80cf2 100644
--- a/include/gensvm_sparse.h
+++ b/include/gensvm_sparse.h
@@ -68,7 +68,7 @@ struct GenSparse {
///< column indices, should be of length nnz
};
-struct GenSparse *gensvm_init_sparse();
+struct GenSparse *gensvm_init_sparse(void);
void gensvm_free_sparse(struct GenSparse *sp);
long gensvm_count_nnz(double *A, long rows, long cols);
bool gensvm_nnz_comparison(long nnz, long rows, long cols);
diff --git a/include/gensvm_task.h b/include/gensvm_task.h
index 77db463..3e180da 100644
--- a/include/gensvm_task.h
+++ b/include/gensvm_task.h
@@ -85,7 +85,7 @@ struct GenTask {
///< performance after cross validation
};
-struct GenTask *gensvm_init_task();
+struct GenTask *gensvm_init_task(void);
struct GenTask *gensvm_copy_task(struct GenTask *t);
void gensvm_free_task(struct GenTask *t);
void gensvm_task_to_model(struct GenTask *task, struct GenModel *model);
diff --git a/src/gensvm_base.c b/src/gensvm_base.c
index 675907d..24b9c71 100644
--- a/src/gensvm_base.c
+++ b/src/gensvm_base.c
@@ -42,7 +42,7 @@
* @returns initialized GenData
*
*/
-struct GenData *gensvm_init_data()
+struct GenData *gensvm_init_data(void)
{
struct GenData *data = Malloc(struct GenData, 1);
data->Sigma = NULL;
@@ -99,7 +99,7 @@ void gensvm_free_data(struct GenData *data)
*
* @returns initialized GenModel
*/
-struct GenModel *gensvm_init_model()
+struct GenModel *gensvm_init_model(void)
{
struct GenModel *model = Malloc(struct GenModel, 1);
diff --git a/src/gensvm_grid.c b/src/gensvm_grid.c
index 984eb96..268880c 100644
--- a/src/gensvm_grid.c
+++ b/src/gensvm_grid.c
@@ -41,7 +41,7 @@
* @return initialized GenGrid struct
*
*/
-struct GenGrid *gensvm_init_grid()
+struct GenGrid *gensvm_init_grid(void)
{
struct GenGrid *grid = Malloc(struct GenGrid, 1);
diff --git a/src/gensvm_kernel.c b/src/gensvm_kernel.c
index a25fcfd..521bddb 100644
--- a/src/gensvm_kernel.c
+++ b/src/gensvm_kernel.c
@@ -52,7 +52,6 @@ void gensvm_kernel_copy_kernelparam_to_data(struct GenModel *model,
data->degree = model->degree;
}
-
/**
* @brief Do the preprocessing steps needed to perform kernel GenSVM
*
diff --git a/src/gensvm_queue.c b/src/gensvm_queue.c
index a72a656..ffa2a82 100644
--- a/src/gensvm_queue.c
+++ b/src/gensvm_queue.c
@@ -35,7 +35,7 @@
*
* @returns initialized GenQueue
*/
-struct GenQueue *gensvm_init_queue()
+struct GenQueue *gensvm_init_queue(void)
{
struct GenQueue *q = Malloc(struct GenQueue, 1);
diff --git a/src/gensvm_sparse.c b/src/gensvm_sparse.c
index 1a9317e..dc4f8df 100644
--- a/src/gensvm_sparse.c
+++ b/src/gensvm_sparse.c
@@ -35,7 +35,7 @@
*
* @return initialized GenSparse instance
*/
-struct GenSparse *gensvm_init_sparse()
+struct GenSparse *gensvm_init_sparse(void)
{
struct GenSparse *sp = Malloc(struct GenSparse, 1);
sp->nnz = 0;
@@ -132,7 +132,6 @@ bool gensvm_could_sparse(double *A, long rows, long cols)
return gensvm_nnz_comparison(nnz, rows, cols);
}
-
/**
* @brief Convert a dense matrix to a GenSparse structure if advantageous
*
diff --git a/src/gensvm_task.c b/src/gensvm_task.c
index 1112c66..a6e239c 100644
--- a/src/gensvm_task.c
+++ b/src/gensvm_task.c
@@ -35,7 +35,7 @@
*
* @returns initialized GenTask
*/
-struct GenTask *gensvm_init_task()
+struct GenTask *gensvm_init_task(void)
{
struct GenTask *t = Malloc(struct GenTask, 1);
diff --git a/src/gensvm_update.c b/src/gensvm_update.c
index 888d406..f7c82cc 100644
--- a/src/gensvm_update.c
+++ b/src/gensvm_update.c
@@ -536,7 +536,6 @@ void gensvm_get_ZAZ_ZB_sparse(struct GenModel *model, struct GenData *data,
}
}
-
/**
* @brief Wrapper around calculation of Z'*A*Z and Z'*B for sparse and dense
*