From d6e9e06edc555fdf73316b7bd222067fc8399828 Mon Sep 17 00:00:00 2001 From: Gertjan van den Burg Date: Wed, 4 Dec 2019 12:30:19 +0000 Subject: Remove 'with nogil' everywhere Don't think it's needed --- gensvm/cython_wrapper/wrapper.pyx | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) (limited to 'gensvm/cython_wrapper/wrapper.pyx') diff --git a/gensvm/cython_wrapper/wrapper.pyx b/gensvm/cython_wrapper/wrapper.pyx index 009e70b..3d7b87d 100644 --- a/gensvm/cython_wrapper/wrapper.pyx +++ b/gensvm/cython_wrapper/wrapper.pyx @@ -88,8 +88,7 @@ def train_wrap( raise ValueError(error_repl) # Do the actual training - with nogil: - gensvm_train(model, data, seed_model) + gensvm_train(model, data, seed_model) # update the number of variables (this may have changed due to kernel) n_var = get_m(model) @@ -137,9 +136,8 @@ def predict_wrap( predictions = np.empty((n_test_obs, ), dtype=np.int) # do the prediction - with nogil: - gensvm_predict(X.data, V.data, n_test_obs, n_var, n_class, - predictions.data) + gensvm_predict(X.data, V.data, n_test_obs, n_var, n_class, + predictions.data) return predictions @@ -174,10 +172,9 @@ def predict_kernels_wrap( cdef np.ndarray[np.int_t, ndim=1, mode='c'] predictions predictions = np.empty((n_obs_test, ), dtype=np.int) - with nogil: - gensvm_predict_kernels(Xtest.data, Xtrain.data, V.data, V_rows, - V_cols, n_obs_train, n_obs_test, n_var, n_class, kernel_idx, - gamma, coef, degree, kernel_eigen_cutoff, predictions.data) + gensvm_predict_kernels(Xtest.data, Xtrain.data, V.data, V_rows, V_cols, + n_obs_train, n_obs_test, n_var, n_class, kernel_idx, gamma, coef, + degree, kernel_eigen_cutoff, predictions.data) return predictions @@ -243,9 +240,7 @@ def grid_wrap( set_queue(queue, n_tasks, tasks) - with nogil: - gensvm_train_q_helper(queue, cv_idx.data, store_predictions, - verbosity) + gensvm_train_q_helper(queue, cv_idx.data, store_predictions, verbosity) cdef np.ndarray[np.int_t, ndim=1, mode='c'] pred cdef np.ndarray[np.double_t, ndim=1, mode='c'] dur -- cgit v1.2.3 From 8a3846d155f90acf850a0de2f02202a6064e0e81 Mon Sep 17 00:00:00 2001 From: Gertjan van den Burg Date: Wed, 4 Dec 2019 12:30:51 +0000 Subject: Use np.int_, since we expect longs --- gensvm/cython_wrapper/wrapper.pyx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gensvm/cython_wrapper/wrapper.pyx') diff --git a/gensvm/cython_wrapper/wrapper.pyx b/gensvm/cython_wrapper/wrapper.pyx index 3d7b87d..cdc54f2 100644 --- a/gensvm/cython_wrapper/wrapper.pyx +++ b/gensvm/cython_wrapper/wrapper.pyx @@ -133,7 +133,7 @@ def predict_wrap( # output vector cdef np.ndarray[np.int_t, ndim=1, mode='c'] predictions - predictions = np.empty((n_test_obs, ), dtype=np.int) + predictions = np.empty((n_test_obs, ), dtype=np.int_) # do the prediction gensvm_predict(X.data, V.data, n_test_obs, n_var, n_class, @@ -259,7 +259,7 @@ def grid_wrap( results['params'].append(candidate_params[ID]) results['scores'].append(get_task_performance(tasks[ID])) if store_predictions: - pred = np.zeros((n_obs, ), dtype=np.int) + pred = np.zeros((n_obs, ), dtype=np.int_) copy_task_predictions(tasks[ID], pred.data, n_obs) results['predictions'].append(pred.copy()) dur = np.zeros((n_folds, ), dtype=np.double) -- cgit v1.2.3 From c4e3edeaaebe68cd47eb9561f0880a44455e3023 Mon Sep 17 00:00:00 2001 From: Gertjan van den Burg Date: Wed, 4 Dec 2019 12:31:07 +0000 Subject: No need to copy, we own the memory --- gensvm/cython_wrapper/wrapper.pyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gensvm/cython_wrapper/wrapper.pyx') diff --git a/gensvm/cython_wrapper/wrapper.pyx b/gensvm/cython_wrapper/wrapper.pyx index cdc54f2..3a85e92 100644 --- a/gensvm/cython_wrapper/wrapper.pyx +++ b/gensvm/cython_wrapper/wrapper.pyx @@ -264,7 +264,7 @@ def grid_wrap( results['predictions'].append(pred.copy()) dur = np.zeros((n_folds, ), dtype=np.double) copy_task_durations(tasks[ID], dur.data, n_folds) - results['durations'].append(dur.copy()) + results['durations'].append(dur) gensvm_free_queue(queue) free_data(data) -- cgit v1.2.3